-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix margin computation in output table #10095
front: fix margin computation in output table #10095
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10095 +/- ##
==========================================
- Coverage 81.53% 81.52% -0.02%
==========================================
Files 1059 1059
Lines 104508 104508
Branches 722 722
==========================================
- Hits 85213 85200 -13
- Misses 19254 19267 +13
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, works well, I don't have the expertise on how margins work, but the code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think you will have to update the unit tests and e2e tests :)
ecd8204
to
94410eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for e2e-tests
c157d00
to
425da03
Compare
Signed-off-by: romainvalls <[email protected]>
425da03
to
750c02d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not tested ✅
close #9737