Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix margin computation in output table #10095

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

RomainValls
Copy link
Contributor

close #9737

@RomainValls RomainValls requested a review from a team as a code owner December 16, 2024 17:29
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 16, 2024
@RomainValls RomainValls self-assigned this Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (0e377b3) to head (750c02d).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10095      +/-   ##
==========================================
- Coverage   81.53%   81.52%   -0.02%     
==========================================
  Files        1059     1059              
  Lines      104508   104508              
  Branches      722      722              
==========================================
- Hits        85213    85200      -13     
- Misses      19254    19267      +13     
  Partials       41       41              
Flag Coverage Δ
editoast 73.69% <ø> (-0.05%) ⬇️
front 89.25% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works well, I don't have the expertise on how margins work, but the code LGTM

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think you will have to update the unit tests and e2e tests :)

@RomainValls RomainValls requested a review from a team as a code owner January 7, 2025 12:30
@RomainValls RomainValls force-pushed the rvs/front-fix-margin-computation-in-output-table branch 3 times, most recently from ecd8204 to 94410eb Compare January 8, 2025 10:20
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e-tests

@RomainValls RomainValls force-pushed the rvs/front-fix-margin-computation-in-output-table branch 3 times, most recently from c157d00 to 425da03 Compare January 9, 2025 09:23
@RomainValls RomainValls force-pushed the rvs/front-fix-margin-computation-in-output-table branch from 425da03 to 750c02d Compare January 9, 2025 09:23
@RomainValls RomainValls requested a review from clarani January 9, 2025 09:53
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested ✅

@RomainValls RomainValls added this pull request to the merge queue Jan 9, 2025
Merged via the queue into dev with commit cdb6f92 Jan 9, 2025
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-margin-computation-in-output-table branch January 9, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Margin Display in Timestop Tables
5 participants