front: drop pathfinding error message bubble #10105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/pathfinding-error-i18n
branch
from
bf6895d to
80e605b
Compare
clarani
approved these changes
Dec 17, 2024
The "pathfindingError" translation needs an "errorMessage" property, so it's not displayed properly. Since the error is already displayed to the user in a different way, we can just drop the bubble. To reproduce: - Select a train in small_infra - Switch to another infra (e.g. France) - Open the "Create new train" modal Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/pathfinding-error-i18n
branch
from
80e605b to
4f7dd40
Compare
emersion
changed the title
|
Updated to drop the error bubble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "pathfindingError" translation needs an "errorMessage" property, so it's not displayed properly.
Since the error is already displayed to the user in a different way, we can just drop the bubble.
To reproduce: