Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: remove duplicate block check #10128

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 19, 2024

This is now checked in the infra explorer anyway (and in a more efficient way)

This is now checked in the infra explorer anyway
(and in a more efficient way)

Signed-off-by: Eloi Charpentier <[email protected]>
@eckter eckter requested a review from a team as a code owner December 19, 2024 09:12
@eckter eckter requested a review from Khoyo December 19, 2024 09:12
@github-actions github-actions bot added the area:core Work on Core Service label Dec 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (ea19025) to head (3e91a26).
Report is 23 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10128      +/-   ##
==========================================
- Coverage   79.82%   79.81%   -0.02%     
==========================================
  Files        1054     1054              
  Lines      105530   105530              
  Branches      726      726              
==========================================
- Hits        84244    84226      -18     
- Misses      21244    21262      +18     
  Partials       42       42              
Flag Coverage Δ
editoast 73.69% <ø> (-0.06%) ⬇️
front 89.14% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@eckter eckter added this pull request to the merge queue Dec 20, 2024
Merged via the queue into dev with commit 7cda595 Dec 20, 2024
27 checks passed
@eckter eckter deleted the ech/remove-duplicate-check branch December 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants