Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: sim: add speed limit anticipation back #10143

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 19, 2024

It was used in v1 but not v2. Includes margins before max speed drops and after it goes up.

Fix #10136

image

Note: this is not applied in STDCM context.

@eckter eckter requested a review from a team as a code owner December 19, 2024 15:39
@eckter eckter requested a review from Khoyo December 19, 2024 15:39
@github-actions github-actions bot added the area:core Work on Core Service label Dec 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (e148616) to head (0742cc5).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10143      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104271   104271              
  Branches      722      722              
==========================================
- Hits        84922    84911      -11     
- Misses      19308    19319      +11     
  Partials       41       41              
Flag Coverage Δ
editoast 73.59% <ø> (-0.04%) ⬇️
front 89.17% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/add-acceleration-anticipation branch 2 times, most recently from 82314f2 to 7192265 Compare December 20, 2024 14:15
@eckter eckter requested a review from a team as a code owner December 20, 2024 14:15
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 20, 2024
@eckter eckter added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@eckter eckter force-pushed the ech/add-acceleration-anticipation branch from 7192265 to fb3eee2 Compare January 6, 2025 09:24
@eckter eckter enabled auto-merge January 6, 2025 09:24
It was used in v1 but not v2. Includes margins before max speed
drops and after it goes up.

Signed-off-by: Eloi Charpentier <[email protected]>
@eckter eckter force-pushed the ech/add-acceleration-anticipation branch from fb3eee2 to 0742cc5 Compare January 6, 2025 15:35
@eckter eckter disabled auto-merge January 6, 2025 15:38
@eckter eckter enabled auto-merge January 6, 2025 15:43
@eckter eckter added this pull request to the merge queue Jan 6, 2025
Merged via the queue into dev with commit fc93efe Jan 6, 2025
27 checks passed
@eckter eckter deleted the ech/add-acceleration-anticipation branch January 6, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: we no longer anticipate the speed limits
4 participants