-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: handle train drag #10151
front: handle train drag #10151
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10151 +/- ##
==========================================
+ Coverage 81.62% 81.65% +0.03%
==========================================
Files 1067 1068 +1
Lines 105624 105850 +226
Branches 727 727
==========================================
+ Hits 86215 86436 +221
- Misses 19368 19373 +5
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ed8a7a5
to
913bfb1
Compare
6607ec8
to
662dcf2
Compare
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left some comments.
Note
Before merging, we should be carefull of some of your commits with spelling mistakes if you keep them :)
front/src/modules/trainschedule/components/Timetable/Timetable.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
662dcf2
to
125fcd9
Compare
Sure, there will be some squash fixup and reword during the rebase |
3093d11
to
bb7d332
Compare
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
7eb5ade
to
e6a8672
Compare
51a7a73
to
290ae89
Compare
Signed-off-by: Math_R_ <[email protected]> front: implement new function to update departureTime after train drag Signed-off-by: Clara Ni <[email protected]> front: fix order to prevent hook to trigger an error Signed-off-by: Math_R_ <[email protected]> front: use a new props to pass the selectedTrain update dispatch - the component keeps the logic to know which element is clicked and what action should be performed Signed-off-by: Math_R_ <[email protected]> front: add a new util function to determine the style of an hovered path Signed-off-by: Math_R_ <[email protected]>
290ae89
to
5a22037
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job
No description provided.