Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: handle train drag #10151

Merged
merged 1 commit into from
Jan 16, 2025
Merged

front: handle train drag #10151

merged 1 commit into from
Jan 16, 2025

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Dec 20, 2024

No description provided.

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65%. Comparing base (c9066aa) to head (5a22037).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10151      +/-   ##
==========================================
+ Coverage   81.62%   81.65%   +0.03%     
==========================================
  Files        1067     1068       +1     
  Lines      105624   105850     +226     
  Branches      727      727              
==========================================
+ Hits        86215    86436     +221     
- Misses      19368    19373       +5     
  Partials       41       41              
Flag Coverage Δ
editoast 73.65% <ø> (-0.02%) ⬇️
front 89.35% <100.00%> (+0.03%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Math-R Math-R force-pushed the mrd/handle-train-drag-2 branch from ed8a7a5 to 913bfb1 Compare January 6, 2025 14:17
@Math-R Math-R marked this pull request as ready for review January 6, 2025 14:18
@Math-R Math-R requested a review from a team as a code owner January 6, 2025 14:18
@Math-R Math-R marked this pull request as draft January 6, 2025 14:34
@Math-R Math-R force-pushed the mrd/handle-train-drag-2 branch 2 times, most recently from 6607ec8 to 662dcf2 Compare January 6, 2025 17:00
@Math-R Math-R marked this pull request as ready for review January 6, 2025 17:01
@emersion emersion removed their assignment Jan 7, 2025
@emersion emersion self-requested a review January 7, 2025 08:44
@emersion emersion changed the title Mrd/handle train drag 2 front: handle train drag 2 Jan 7, 2025
@emersion emersion changed the title front: handle train drag 2 front: handle train drag Jan 7, 2025
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left some comments.

Note

Before merging, we should be carefull of some of your commits with spelling mistakes if you keep them :)

@Math-R Math-R force-pushed the mrd/handle-train-drag-2 branch from 662dcf2 to 125fcd9 Compare January 8, 2025 14:07
@Math-R
Copy link
Contributor Author

Math-R commented Jan 8, 2025

Thank you for the PR, left some comments.

Note

Before merging, we should be carefull of some of your commits with spelling mistakes if you keep them :)

Sure, there will be some squash fixup and reword during the rebase

@Math-R Math-R requested a review from SharglutDev January 8, 2025 15:12
@Math-R Math-R force-pushed the mrd/handle-train-drag-2 branch from 3093d11 to bb7d332 Compare January 9, 2025 09:05
@Math-R Math-R requested a review from SharglutDev January 14, 2025 11:52
@Math-R Math-R force-pushed the mrd/handle-train-drag-2 branch 5 times, most recently from 7eb5ade to e6a8672 Compare January 16, 2025 10:31
@Math-R Math-R enabled auto-merge January 16, 2025 10:37
@Math-R Math-R force-pushed the mrd/handle-train-drag-2 branch 2 times, most recently from 51a7a73 to 290ae89 Compare January 16, 2025 15:17
Signed-off-by: Math_R_ <[email protected]>

front: implement new function to update departureTime after train drag

Signed-off-by: Clara Ni <[email protected]>

front: fix order to prevent hook to trigger an error

Signed-off-by: Math_R_ <[email protected]>

front: use a new props to pass the selectedTrain update dispatch

- the component keeps the logic to know which element is clicked and what action should be performed

Signed-off-by: Math_R_ <[email protected]>

front: add a new util function to determine the style of an hovered path

Signed-off-by: Math_R_ <[email protected]>
@Math-R Math-R force-pushed the mrd/handle-train-drag-2 branch from 290ae89 to 5a22037 Compare January 16, 2025 15:32
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job

@Math-R Math-R added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@SharglutDev SharglutDev added this pull request to the merge queue Jan 16, 2025
Merged via the queue into dev with commit d7e5438 Jan 16, 2025
27 checks passed
@SharglutDev SharglutDev deleted the mrd/handle-train-drag-2 branch January 16, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants