front: remove PathStep casts #10167
Merged
front: remove PathStep casts #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use a null assertion. This is safer in case the return type of useSelector(getPathSteps) changes. Signed-off-by: Simon Ser <[email protected]>
We don't need to do anything special wrt secondary_code here. Signed-off-by: Simon Ser <[email protected]>
With the refactoring in the previous commit, TypeScript is smart enough to figure out that the value we return has the correct shape. Signed-off-by: Simon Ser <[email protected]>
…ducer This is safer in case the type of state.pathSteps is changed to something else. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/rm-path-step-casts
branch
from
7d46735 to
be0acbb
Compare
TypeScript is not smart enough to understand that the result of omit() is a PathItemLocation. Use standard JavaScript destructuring instead. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/rm-path-step-casts
branch
from
be0acbb to
6e4f7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.