Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: bump typescript 5.7 #10228

Merged
merged 2 commits into from
Jan 3, 2025
Merged

front: bump typescript 5.7 #10228

merged 2 commits into from
Jan 3, 2025

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Jan 3, 2025

See commits.

Note

There might be some other enhancements possible among the code with these new versions.

Should be merged after #10084

close #10081

@SharglutDev SharglutDev requested review from emersion and Yohh January 3, 2025 10:23
@SharglutDev SharglutDev requested a review from a team as a code owner January 3, 2025 10:23
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.42%. Comparing base (663a418) to head (c6da206).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...nt/src/modules/pathfinding/hooks/usePathfinding.ts 0.00% 5 Missing ⚠️
...components/RollingStockEditor/CurveSpreadsheet.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10228      +/-   ##
==========================================
- Coverage   81.44%   81.42%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104275   104271       -4     
  Branches      723      722       -1     
==========================================
- Hits        84923    84900      -23     
- Misses      19310    19330      +20     
+ Partials       42       41       -1     
Flag Coverage Δ
editoast 73.55% <ø> (-0.08%) ⬇️
front 89.17% <45.45%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev requested a review from a team as a code owner January 3, 2025 11:59
@SharglutDev SharglutDev force-pushed the pfn/front/bump-typescript-5.7 branch from 572f26c to cf718f2 Compare January 3, 2025 12:08
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@emersion emersion changed the title bump typescript 5.7 front: bump typescript 5.7 Jan 3, 2025
Fix some warnings

Signed-off-by: SharglutDev <[email protected]>
Since v5.5, typescript now remembers that the pathstep are all not null after the condition

Signed-off-by: SharglutDev <[email protected]>
@SharglutDev SharglutDev force-pushed the pfn/front/bump-typescript-5.7 branch from cf718f2 to c6da206 Compare January 3, 2025 14:37
@SharglutDev SharglutDev enabled auto-merge January 3, 2025 14:37
@SharglutDev SharglutDev added this pull request to the merge queue Jan 3, 2025
Merged via the queue into dev with commit 3d3a8fc Jan 3, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/bump-typescript-5.7 branch January 3, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to typescript 5.7
4 participants