Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix adding intermediate points hides the result table and result map #10266

Merged
merged 1 commit into from
Jan 7, 2025
Merged

front: fix adding intermediate points hides the result table and result map #10266

merged 1 commit into from
Jan 7, 2025

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Jan 7, 2025

close #10204

@kmer2016 kmer2016 requested a review from a team as a code owner January 7, 2025 08:45
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 7, 2025
@kmer2016 kmer2016 changed the title front: update event listener to use parent element for animation end front: fix adding intermediate points hides the result table and result map Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (18e4c0d) to head (cacc596).
Report is 15 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10266      +/-   ##
==========================================
- Coverage   81.45%   81.43%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104282   104286       +4     
  Branches      722      722              
==========================================
- Hits        84938    84930       -8     
- Misses      19303    19315      +12     
  Partials       41       41
Flag Coverage Δ
editoast 73.59% <ø> (-0.04%) ⬇️
front 89.18% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SharglutDev
SharglutDev approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@kmer2016 kmer2016 force-pushed the cnh/front-fix-intermediate-points-scroll branch from ae78c18 to cacc596 Compare January 7, 2025 10:56
@kmer2016 kmer2016 added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@kmer2016 kmer2016 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into dev with commit f4150c0 Jan 7, 2025
27 checks passed
@kmer2016 kmer2016 deleted the cnh/front-fix-intermediate-points-scroll branch January 7, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@emersion emersion emersion approved these changes

@achrafmohye achrafmohye Awaiting requested review from achrafmohye

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stdcm: adding intermediate points hides the result table and result map
4 participants
@kmer2016 @codecov-commenter @emersion @SharglutDev