front: enhance viewport computation function #10268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10268 +/- ##
==========================================
+ Coverage 81.45% 81.52% +0.07%
==========================================
Files 1058 1059 +1
Lines 104282 104508 +226
Branches 722 722
==========================================
+ Hits 84938 85200 +262
+ Misses 19303 19267 -36
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emersion
changed the title
SarahBellaha
reviewed
Jan 8, 2025
SharglutDev
reviewed
Jan 8, 2025
Adding optional parameters on function `computeBBoxViewport` to take care of the map height/width Related to #10240 & #10144 Signed-off-by: Benoit Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding optional parameters on function
computeBBoxViewportto take care of the map height/widthRelated to #10240 & #10144
NOTE: I also increased the padding to be bigger than the button on the map (it avoid to be hidden by them).