Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmr: add messages during pathfinding and when its done #10282

Merged
merged 1 commit into from
Jan 17, 2025
Merged

lmr: add messages during pathfinding and when its done #10282

merged 1 commit into from
Jan 17, 2025

Conversation

Caracol3
Copy link
Contributor

@Caracol3 Caracol3 commented Jan 8, 2025 •
edited
Loading

close #9451

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (ec18e08) to head (cf77fd1).
Report is 7 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #10282   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files        1073     1073           
  Lines      106492   106543   +51     
  Branches      727      727           
=======================================
+ Hits        87095    87137   +42     
- Misses      19358    19367    +9     
  Partials       39       39
Flag Coverage Δ
editoast 74.18% <ø> (-0.03%) ⬇️
front 89.36% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 7db40cf to 11b864d Compare January 8, 2025 15:27
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 11b864d to 4466b01 Compare January 9, 2025 09:11
@Caracol3 Caracol3 marked this pull request as ready for review January 9, 2025 09:12
@Caracol3 Caracol3 requested a review from a team as a code owner January 9, 2025 09:12
@Caracol3 Caracol3 requested review from theocrsb and kmer2016 January 9, 2025 09:12
theocrsb
theocrsb reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I have these two messages at the same time

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 4466b01 to 21cecc9 Compare January 9, 2025 09:41
@kmer2016 kmer2016 requested review from Math-R and removed request for kmer2016 January 9, 2025 10:35
@Caracol3
Copy link
Contributor Author

Caracol3 commented Jan 9, 2025

image

I have these two messages at the same time

This is weird, i never had this. Did you restart the front ?

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 891d6f5 to 64545da Compare January 9, 2025 11:25
Math-R
Math-R previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm tested & live reviewed with @Caracol3

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 64545da to d883f75 Compare January 9, 2025 11:37
@theocrsb
Copy link
Contributor

theocrsb commented Jan 9, 2025 •
edited
Loading

image I have these two messages at the same time

This is weird, i never had this. Did you restart the front ?

Yes, You can try these inputs

image

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch 2 times, most recently from 58ec549 to 3f1f173 Compare January 9, 2025 11:47
@Math-R Math-R dismissed their stale review January 9, 2025 12:08

need to fix the double message display

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 3f1f173 to 105c48f Compare January 9, 2025 12:28
@Caracol3 Caracol3 requested review from theocrsb and Math-R January 9, 2025 12:35
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch 2 times, most recently from d264d5e to 82a5eb1 Compare January 9, 2025 14:31
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 82a5eb1 to bc9236d Compare January 9, 2025 15:15
theocrsb
theocrsb approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from bc9236d to 6a320cc Compare January 10, 2025 09:51
Math-R
Math-R approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 6a320cc to 879bec5 Compare January 10, 2025 10:42
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch 2 times, most recently from 0ca4d71 to dbe41e7 Compare January 15, 2025 10:55
SharglutDev
SharglutDev reviewed Jan 15, 2025
View reviewed changes
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch 2 times, most recently from 5b7554b to 2536ad2 Compare January 16, 2025 14:41
SharglutDev
SharglutDev reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments we discussed (+1 bonus) not to forget them

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch 2 times, most recently from 3f1a4d0 to c86a28e Compare January 17, 2025 10:03
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch 2 times, most recently from 230795b to 18ce1f9 Compare January 17, 2025 13:39
@SharglutDev SharglutDev force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 18ce1f9 to 4e6068d Compare January 17, 2025 16:25
emersion
emersion approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, feel free to resolve!

@Caracol3 @RomainValls @SharglutDev
lmr: add messages during pathfinding and when its done
cf77fd1 
- fix padding, add translations
- refacto using isfetching from rtk
- add transition in css to avoid two settimeout
- add eventlistener for the animation

Signed-off-by: Mathieu <[email protected]>
Co-authored-by: romainvalls <[email protected]>
@SharglutDev SharglutDev force-pushed the mcy/front-lmr-display-new-messages-during-pathfinding branch from 4e6068d to cf77fd1 Compare January 17, 2025 16:52
@SharglutDev SharglutDev enabled auto-merge January 17, 2025 17:00
@SharglutDev SharglutDev added this pull request to the merge queue Jan 17, 2025
Merged via the queue into dev with commit c4c4c58 Jan 17, 2025
27 checks passed
@SharglutDev SharglutDev deleted the mcy/front-lmr-display-new-messages-during-pathfinding branch January 17, 2025 17:31
@SharglutDev SharglutDev mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

@SharglutDev SharglutDev SharglutDev left review comments

@Math-R Math-R Math-R approved these changes

@theocrsb theocrsb theocrsb approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obtenir la simulation button doesn't send a request when there's no pathfinding
6 participants
@Caracol3 @codecov-commenter @theocrsb @emersion @Math-R @SharglutDev