core: fix max speed in concatenated envelopes #10312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10312 +/- ##
==========================================
+ Coverage 81.56% 81.61% +0.04%
==========================================
Files 1062 1063 +1
Lines 104953 105426 +473
Branches 722 722
==========================================
+ Hits 85608 86046 +438
- Misses 19304 19339 +35
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Erashin
approved these changes
Jan 9, 2025
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/EnvelopeConcat.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Eloi Charpentier <[email protected]>
eckter
force-pushed
the
ech/fix-max-speed
branch
from
78e98d2 to
3ce4cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was a single envelope, we'd actually return the maximum value over the whole envelope, ignoring ranges.
This caused a nasty bug in stdcm where the "max speed" would be higher in post-processing than during the graph traversal, resulting in conflict mismatches (when using TVM)