Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: reorganize infra object layers #10319

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 10, 2025

Tidy a bit the layers: move all the infra layers in a special directory

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 10, 2025
@clarani clarani self-assigned this Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.02985% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.87%. Comparing base (586b13c) to head (ee0189a).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
...t/src/common/Map/Layers/InfraObjectLayers/index.ts 0.00% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10319      +/-   ##
==========================================
+ Coverage   81.83%   81.87%   +0.03%     
==========================================
  Files        1073     1077       +4     
  Lines      107058   107088      +30     
  Branches      728      724       -4     
==========================================
+ Hits        87613    87676      +63     
+ Misses      19406    19372      -34     
- Partials       39       40       +1     
Flag Coverage Δ
editoast 74.16% <ø> (-0.09%) ⬇️
front 89.44% <94.02%> (+0.07%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/tidy-infra-object-layers branch from f08dfb0 to 0a9f19f Compare January 10, 2025 13:24
@clarani clarani force-pushed the cni/tidy-infra-object-layers branch from 0a9f19f to c4b781a Compare January 20, 2025 13:03
@clarani clarani marked this pull request as ready for review January 20, 2025 13:07
@clarani clarani requested a review from a team as a code owner January 20, 2025 13:07
@clarani clarani force-pushed the cni/tidy-infra-object-layers branch from c4b781a to 1d5ff7d Compare February 3, 2025 10:48
@clarani clarani enabled auto-merge February 3, 2025 11:07
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. Tested, just a comment.

@clarani clarani force-pushed the cni/tidy-infra-object-layers branch from 1d5ff7d to ee0189a Compare February 3, 2025 16:36
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clarani clarani added this pull request to the merge queue Feb 4, 2025
Merged via the queue into dev with commit ce5d15b Feb 4, 2025
27 checks passed
@clarani clarani deleted the cni/tidy-infra-object-layers branch February 4, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants