Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add weight documentation #10344

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Jan 13, 2025

documentation: add precision about weight field

@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (0ee63cf) to head (a95929a).
Report is 39 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10344      +/-   ##
==========================================
- Coverage   81.65%   81.63%   -0.02%     
==========================================
  Files        1065     1066       +1     
  Lines      105650   105735      +85     
  Branches      723      727       +4     
==========================================
+ Hits        86265    86314      +49     
- Misses      19344    19380      +36     
  Partials       41       41              
Flag Coverage Δ
editoast 73.63% <ø> (-0.05%) ⬇️
front 89.33% <ø> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the tce/add-weight-documentation branch from f11fa90 to b8b1468 Compare January 14, 2025 10:01
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 14, 2025
@younesschrifi younesschrifi marked this pull request as ready for review January 14, 2025 10:05
@younesschrifi younesschrifi requested a review from a team as a code owner January 14, 2025 10:05
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once @leovalais comment fixed)

@younesschrifi younesschrifi force-pushed the tce/add-weight-documentation branch from b8b1468 to a045e74 Compare January 15, 2025 13:24
Signed-off-by: theocrsb <[email protected]>
Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
@younesschrifi younesschrifi force-pushed the tce/add-weight-documentation branch from a045e74 to a95929a Compare January 15, 2025 13:38
@github-actions github-actions bot removed the area:front Work on Standard OSRD Interface modules label Jan 15, 2025
@younesschrifi younesschrifi added this pull request to the merge queue Jan 15, 2025
Merged via the queue into dev with commit 9ddc06c Jan 15, 2025
27 checks passed
@younesschrifi younesschrifi deleted the tce/add-weight-documentation branch January 15, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants