Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove unused class in stdcm results #10379

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Jan 14, 2025

Since a recent PR, this class isn't used anymore.

@SharglutDev SharglutDev added the area:front Work on Standard OSRD Interface modules label Jan 14, 2025
@SharglutDev SharglutDev self-assigned this Jan 14, 2025
@SharglutDev SharglutDev requested a review from a team as a code owner January 14, 2025 13:38
@SharglutDev SharglutDev enabled auto-merge January 14, 2025 13:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (6b9c52f) to head (9e6ab79).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10379      +/-   ##
==========================================
- Coverage   81.64%   81.64%   -0.01%     
==========================================
  Files        1066     1066              
  Lines      105692   105692              
  Branches      727      727              
==========================================
- Hits        86297    86296       -1     
- Misses      19354    19355       +1     
  Partials       41       41              
Flag Coverage Δ
editoast 73.68% <ø> (-0.01%) ⬇️
front 89.33% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SharglutDev SharglutDev added this pull request to the merge queue Jan 14, 2025
Merged via the queue into dev with commit 8ea2ad9 Jan 14, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/stdcm-result-remove-unused-class branch January 14, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants