Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: bump osrd-ui packages to 0.0.62 #10403

Merged
merged 1 commit into from
Jan 17, 2025
Merged

front: bump osrd-ui packages to 0.0.62 #10403

merged 1 commit into from
Jan 17, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 16, 2025

closes #10309
closes #10314

@clarani clarani requested a review from a team as a code owner January 16, 2025 10:17
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 16, 2025
@clarani clarani requested review from SharglutDev and kmer2016 and removed request for SharglutDev January 16, 2025 10:17
@clarani clarani enabled auto-merge January 16, 2025 10:18
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.66%. Comparing base (00df2a1) to head (7afa18c).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10403      +/-   ##
==========================================
- Coverage   81.67%   81.66%   -0.01%     
==========================================
  Files        1071     1071              
  Lines      106118   106118              
  Branches      727      727              
==========================================
- Hits        86673    86665       -8     
- Misses      19406    19414       +8     
  Partials       39       39              
Flag Coverage Δ
editoast 73.72% <ø> (-0.03%) ⬇️
front 89.36% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@clarani clarani added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first fix is fine, but the second one doesn't seem to work

image

@kmer2016
Copy link
Contributor

The first fix is fine, but the second one doesn't seem to work

image

False alarm, the issue was with my local environment.

@clarani clarani added this pull request to the merge queue Jan 16, 2025
@clarani clarani removed this pull request from the merge queue due to a manual request Jan 16, 2025
@clarani clarani force-pushed the cni/bump-osrd-ui-0.0.62 branch from e6c1d5b to 7afa18c Compare January 17, 2025 10:07
@clarani clarani enabled auto-merge January 17, 2025 10:07
@clarani clarani added this pull request to the merge queue Jan 17, 2025
Merged via the queue into dev with commit bf85a79 Jan 17, 2025
27 checks passed
@clarani clarani deleted the cni/bump-osrd-ui-0.0.62 branch January 17, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
4 participants