Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frontend nginx version #10417

Closed
wants to merge 1 commit into from
Closed

Remove frontend nginx version #10417

wants to merge 1 commit into from

Conversation

flomonster
Copy link
Contributor

  • Use the gateway-front in the e2e tests
  • Simplify the integration tests step removing gateway and front images

@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:ci Work on Continous Integration Pipeline Service area:gateway labels Jan 16, 2025
@flomonster flomonster changed the title ci: remove nginx version of the frontend Remove frontend nginx version Jan 16, 2025
- Use the gateway-front in the e2e tests
- Simplify the integration tests step removing gateway and front images

Signed-off-by: Florian Amsallem <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (accd619) to head (db89c1a).
Report is 192 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10417      +/-   ##
==========================================
- Coverage   81.62%   81.60%   -0.03%     
==========================================
  Files        1070     1070              
  Lines      105881   105881              
  Branches      727      727              
==========================================
- Hits        86428    86400      -28     
- Misses      19412    19440      +28     
  Partials       41       41              
Flag Coverage Δ
editoast 73.66% <ø> (-0.09%) ⬇️
front 89.32% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster assigned flomonster and ElysaSrc and unassigned flomonster Jan 17, 2025
@flomonster
Copy link
Contributor Author

Done here: #10502

@flomonster flomonster closed this Feb 6, 2025
@flomonster flomonster deleted the fam/trash-nginx branch February 20, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Work on Continous Integration Pipeline Service area:front Work on Standard OSRD Interface modules area:gateway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants