front: fix electrical profiles in csv export #10420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10420 +/- ##
==========================================
- Coverage 81.67% 81.67% -0.01%
==========================================
Files 1071 1071
Lines 106118 106127 +9
Branches 727 727
==========================================
+ Hits 86673 86674 +1
- Misses 19406 19414 +8
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yohh
force-pushed
the
yoh/front-fix-simulation-csv-export
branch
from
68927cd to
1a81603
Compare
Math-R
reviewed
Jan 17, 2025
front/src/modules/simulationResult/SimulationResultExport/exportTrainCSV.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/SimulationResultExport/exportTrainCSV.ts
Outdated
Show resolved
Hide resolved
Yohh
force-pushed
the
yoh/front-fix-simulation-csv-export
branch
from
a3fc5e0 to
03738e7
Compare
Yohh
force-pushed
the
yoh/front-fix-simulation-csv-export
branch
from
03738e7 to
129cfed
Compare
in exportTrainCSV.ts electrical profiles are based on electrificationRanges, which are not the good ones use simulatedTrain.electrical_profiles instead Co-authored-by: Math_R_ <[email protected]> Signed-off-by: Yohh <[email protected]>
Yohh
force-pushed
the
yoh/front-fix-simulation-csv-export
branch
from
129cfed to
15b93a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in exportTrainCSV.ts electrical profiles are based on electrificationRanges, which are not the good ones
use simulatedTrain.electrical_profiles instead
close #9345