Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: use the right limit when shifting departure time #10429

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jan 17, 2025

No description provided.

@eckter eckter requested a review from Erashin January 17, 2025 14:25
@eckter eckter requested a review from a team as a code owner January 17, 2025 14:25
@github-actions github-actions bot added the area:core Work on Core Service label Jan 17, 2025
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, that's better.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (1f61563) to head (d8d5561).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10429      +/-   ##
==========================================
+ Coverage   81.67%   81.77%   +0.09%     
==========================================
  Files        1071     1073       +2     
  Lines      106128   106492     +364     
  Branches      727      727              
==========================================
+ Hits        86683    87084     +401     
+ Misses      19406    19369      -37     
  Partials       39       39              
Flag Coverage Δ
editoast 74.17% <ø> (+0.42%) ⬆️
front 89.36% <ø> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/fix-first-departure-delaying branch from 807132e to d8d5561 Compare January 17, 2025 14:34
@eckter eckter enabled auto-merge January 17, 2025 14:34
@eckter eckter added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@eckter eckter added this pull request to the merge queue Jan 17, 2025
Merged via the queue into dev with commit bcbc767 Jan 17, 2025
27 checks passed
@eckter eckter deleted the ech/fix-first-departure-delaying branch January 17, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants