Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display only trains around stdcm result #10432

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 17, 2025

closes #9131

@emersion emersion self-requested a review January 17, 2025 15:54
@clarani clarani force-pushed the cni/9131-display-only-trains-around-stdcm-result branch from 2b20c62 to c586622 Compare January 17, 2025 16:10
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 17, 2025
@clarani clarani marked this pull request as ready for review January 17, 2025 16:16
@clarani clarani requested a review from a team as a code owner January 17, 2025 16:16
@bloussou
Copy link
Contributor

changed

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (23a21ce) to head (576d732).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10432   +/-   ##
=======================================
  Coverage   81.80%   81.81%           
=======================================
  Files        1073     1073           
  Lines      106606   106664   +58     
  Branches      731      730    -1     
=======================================
+ Hits        87214    87266   +52     
- Misses      19353    19359    +6     
  Partials       39       39           
Flag Coverage Δ
editoast 74.29% <ø> (-0.01%) ⬇️
front 89.34% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisgreiner
Copy link
Contributor

louisgreiner commented Jan 22, 2025

Nice ! Actually could also fix this #10337

@emersion
Copy link
Member

The first and last commits are reviewed-by me. The middle commit "front: display only trains around the stdcm train on the GET in debug mode" is not.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@clarani clarani force-pushed the cni/9131-display-only-trains-around-stdcm-result branch from d76436e to 576d732 Compare January 23, 2025 10:44
@clarani clarani enabled auto-merge January 23, 2025 10:44
@clarani clarani added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit fff6686 Jan 23, 2025
27 checks passed
@clarani clarani deleted the cni/9131-display-only-trains-around-stdcm-result branch January 23, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: only display trains that surround the result in the GET
5 participants