-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: display only trains around stdcm result #10432
front: display only trains around stdcm result #10432
Conversation
2b20c62
to
c586622
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10432 +/- ##
=======================================
Coverage 81.80% 81.81%
=======================================
Files 1073 1073
Lines 106606 106664 +58
Branches 731 730 -1
=======================================
+ Hits 87214 87266 +52
- Misses 19353 19359 +6
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice ! Actually could also fix this #10337 |
front/src/applications/operationalStudies/hooks/useScenarioData.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/StdcmDebugResults.tsx
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useLazyLoadTrains.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/hooks/useProjectedTrainsForStdcm.ts
Outdated
Show resolved
Hide resolved
The first and last commits are reviewed-by me. The middle commit "front: display only trains around the stdcm train on the GET in debug mode" is not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
Signed-off-by: Clara Ni <[email protected]>
… mode Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
d76436e
to
576d732
Compare
closes #9131