Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: clean up etcs braking simulator #10440

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Jan 20, 2025

Rest of the clean ups commented by @bougue-pe in #10316

@Erashin Erashin requested a review from a team as a code owner January 20, 2025 10:31
@Erashin Erashin requested review from Khoyo, eckter and bougue-pe January 20, 2025 10:31
@github-actions github-actions bot added the area:core Work on Core Service label Jan 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (c4c4c58) to head (345a58f).
Report is 9 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10440      +/-   ##
==========================================
- Coverage   81.79%   81.78%   -0.02%     
==========================================
  Files        1073     1073              
  Lines      106543   106574      +31     
  Branches      727      731       +4     
==========================================
+ Hits        87147    87157      +10     
- Misses      19357    19378      +21     
  Partials       39       39              
Flag Coverage Δ
editoast 74.21% <ø> (+<0.01%) ⬆️
front 89.34% <ø> (-0.03%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/core/clean_etcs_braking_sim branch 2 times, most recently from 2486d6b to fa65585 Compare January 20, 2025 11:06
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Erashin Erashin force-pushed the alch/core/clean_etcs_braking_sim branch from fa65585 to 3e58cf6 Compare January 20, 2025 13:02
@Erashin Erashin added this pull request to the merge queue Jan 20, 2025
@Erashin Erashin removed this pull request from the merge queue due to a manual request Jan 20, 2025
@Erashin Erashin force-pushed the alch/core/clean_etcs_braking_sim branch 2 times, most recently from 219d0d3 to 1c23c64 Compare January 20, 2025 14:31
@Erashin Erashin force-pushed the alch/core/clean_etcs_braking_sim branch from 1c23c64 to 345a58f Compare January 20, 2025 14:38
@Erashin Erashin enabled auto-merge January 20, 2025 14:48
@Erashin Erashin added this pull request to the merge queue Jan 20, 2025
Merged via the queue into dev with commit b828d20 Jan 20, 2025
27 checks passed
@Erashin Erashin deleted the alch/core/clean_etcs_braking_sim branch January 20, 2025 15:25
@Erashin Erashin self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants