Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rolling stock, effort curve documentation #10441

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

flomonster
Copy link
Contributor

@celine-sncf spotted a lack of documentation.

@flomonster flomonster requested a review from a team as a code owner January 20, 2025 13:02
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 20, 2025
@flomonster flomonster self-assigned this Jan 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (1fe7f70) to head (56949ac).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10441      +/-   ##
==========================================
- Coverage   81.81%   81.80%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106718   106718              
  Branches      730      730              
==========================================
- Hits        87307    87302       -5     
- Misses      19372    19377       +5     
  Partials       39       39              
Flag Coverage Δ
editoast 74.28% <ø> (-0.02%) ⬇️
front 89.34% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the fam/add-doc-effort-curve branch from f8c378f to 860699e Compare January 20, 2025 14:26
@flomonster flomonster force-pushed the fam/add-doc-effort-curve branch from 860699e to fbc5e7d Compare January 20, 2025 15:18
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 20, 2025
@flomonster flomonster force-pushed the fam/add-doc-effort-curve branch from fbc5e7d to 068d397 Compare January 21, 2025 08:38
@flomonster flomonster enabled auto-merge January 21, 2025 08:38
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where is uom where we need it @Tristramg 😅 Looks good enough to improve the documentation. Thank you!

@flomonster flomonster force-pushed the fam/add-doc-effort-curve branch from 068d397 to 56949ac Compare January 24, 2025 14:00
@flomonster flomonster added this pull request to the merge queue Jan 24, 2025
Merged via the queue into dev with commit 61fd031 Jan 24, 2025
27 checks passed
@flomonster flomonster deleted the fam/add-doc-effort-curve branch January 24, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants