-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: lmr fix intermediate op id collision #10445
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10445 +/- ##
==========================================
- Coverage 81.81% 81.81% -0.01%
==========================================
Files 1073 1073
Lines 106664 106666 +2
Branches 730 730
==========================================
Hits 87267 87267
- Misses 19358 19360 +2
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0d874d9
to
99e2f7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested (you probably need to rebase)
5e50aa7
to
ce5bb6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine although, I'm pretty sure I don't understand it in the details 😄
713166f
to
58be440
Compare
b78ddb6
to
dce1f31
Compare
Signed-off-by: Egor Berezovskiy <[email protected]>
dce1f31
to
2dd16b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for e2e tests
fix #10375
Use UUID instead of react-id-generator. The latter is a sequential ID generator with a global counter that can reset when the page is refreshed and data is restored from localStorage or the window object, potentially resulting in duplicated IDs.