Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: lmr fix intermediate op id collision #10445

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jan 20, 2025

fix #10375

Use UUID instead of react-id-generator. The latter is a sequential ID generator with a global counter that can reset when the page is refreshed and data is restored from localStorage or the window object, potentially resulting in duplicated IDs.

  • Fix tests

@Wadjetz Wadjetz added area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM labels Jan 20, 2025
@Wadjetz Wadjetz self-assigned this Jan 20, 2025
@Wadjetz Wadjetz marked this pull request as ready for review January 20, 2025 13:51
@Wadjetz Wadjetz requested a review from a team as a code owner January 20, 2025 13:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (5bd1d85) to head (2dd16b7).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10445      +/-   ##
==========================================
- Coverage   81.81%   81.81%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106664   106666       +2     
  Branches      730      730              
==========================================
  Hits        87267    87267              
- Misses      19358    19360       +2     
  Partials       39       39              
Flag Coverage Δ
editoast 74.29% <ø> (-0.01%) ⬇️
front 89.34% <83.33%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/front/lmr-fix-intermediate-op-id-collision branch 3 times, most recently from 0d874d9 to 99e2f7a Compare January 21, 2025 08:28
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested (you probably need to rebase)

@Wadjetz Wadjetz force-pushed the ebe/front/lmr-fix-intermediate-op-id-collision branch 2 times, most recently from 5e50aa7 to ce5bb6f Compare January 22, 2025 08:25
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine although, I'm pretty sure I don't understand it in the details 😄

@Wadjetz Wadjetz force-pushed the ebe/front/lmr-fix-intermediate-op-id-collision branch from 713166f to 58be440 Compare January 22, 2025 13:45
@Wadjetz Wadjetz requested a review from a team as a code owner January 22, 2025 15:15
@Wadjetz Wadjetz force-pushed the ebe/front/lmr-fix-intermediate-op-id-collision branch 4 times, most recently from b78ddb6 to dce1f31 Compare January 23, 2025 11:20
@Wadjetz Wadjetz requested a review from Maymanaf January 23, 2025 11:44
@Wadjetz Wadjetz force-pushed the ebe/front/lmr-fix-intermediate-op-id-collision branch from dce1f31 to 2dd16b7 Compare January 23, 2025 11:49
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e tests

@Wadjetz Wadjetz added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit c2228f0 Jan 23, 2025
27 checks passed
@Wadjetz Wadjetz deleted the ebe/front/lmr-fix-intermediate-op-id-collision branch January 23, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: multiple intermediate OP are changed together
6 participants