front: fix macro trainruns frequencies

[louisgreiner]

After #9105, we've lost the feature the macro trainrun frequencies

This way of handling macro train frequencies will be revamp during https://github.com/osrd-project/osrd-confidential/issues/779

Closes #10389
Closes #10552

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (ce5d15b) to head (c9c33f8).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev   #10448   +/-   ##
=======================================
  Coverage   81.87%   81.88%           
=======================================
  Files        1077     1078    +1     
  Lines      107088   107144   +56     
  Branches      724      724           
=======================================
+ Hits        87681    87736   +55     
- Misses      19367    19368    +1     
  Partials       40       40           

Flag	Coverage Δ
editoast	74.18% <ø> (-0.01%)	⬇️
front	89.45% <100.00%> (+<0.01%)	⬆️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[louisgreiner]

Depends on #10486

[SharglutDev]

Works great just some questions :)

[emersion]

It seems like this feature got lost in #9105.

I think this PR still creates frequency:: labels in NGE (without using them in any trainrun)?

[louisgreiner]

frequency:: labels should be shared in NGE if they are not either frequency::30, or frequency::60 or frequency::120.

The former feature allowed, for instance, frequency::10 to be shared in NGE, even tho we don't match this frequency with an actual NGE frequency

@emersion

[emersion]

Yeah, what I meant was that I think frequency::30 and friends show up as a regular label in NGE with this PR.

[emersion]

I'm not a huge fan of the RegExp-based label parsing. (BTW, it's also used in ngeToOsrd.)

Maybe this can all be consolidated in a single function, used everywhere instead of the RegExp and string checks?

const frequencyIdFromLabel = (label: string) => {
  if (!label.startsWith('frequency::')) return null;
  const n = parseInt(label.split('::', 2)[1], 10);
  const frequency = DEFAULT_TRAINRUN_FREQUENCIES.find((freq) => freq.frequency === n);
  return frequency?.id ?? null;
};

[louisgreiner]

Because I found this bug on the way, i'm also fixing it in a separate commit : #10552

[SharglutDev]

Lgtm and tested, good job :)

[Uriel-Sautron]

LGTM, tested.

[Uriel-Sautron]

LGTM, tested.