Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: stdcm: stop awaiting the log entry creation #10453

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Jan 20, 2025

Fixes part of #10452

@Khoyo Khoyo requested a review from a team as a code owner January 20, 2025 17:23
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 20, 2025
@Khoyo Khoyo force-pushed the yk/dont-await-after-spawn branch from c33dc61 to e001ec7 Compare January 20, 2025 17:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (b828d20) to head (7fae3d9).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10453      +/-   ##
==========================================
- Coverage   81.78%   81.78%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106580   106579       -1     
  Branches      731      731              
==========================================
- Hits        87167    87165       -2     
- Misses      19374    19375       +1     
  Partials       39       39              
Flag Coverage Δ
editoast 74.22% <100.00%> (-0.01%) ⬇️
front 89.34% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch (not tested)

@Khoyo Khoyo force-pushed the yk/dont-await-after-spawn branch from e001ec7 to 7fae3d9 Compare January 21, 2025 06:49
@Khoyo Khoyo self-assigned this Jan 21, 2025
@Khoyo Khoyo added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@Khoyo Khoyo added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@Khoyo Khoyo added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@Khoyo Khoyo added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@Khoyo Khoyo added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@Khoyo Khoyo added this pull request to the merge queue Jan 21, 2025
Merged via the queue into dev with commit 11d7941 Jan 21, 2025
27 checks passed
@Khoyo Khoyo deleted the yk/dont-await-after-spawn branch January 21, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants