Fix unrecognized op and preserve invalid state

[achrafmohye]

Closes #10396

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (eeb8aa2) to head (17e44ae).
Report is 143 commits behind head on dev.

Files with missing lines	Patch %	Lines
...nt/src/modules/pathfinding/hooks/usePathfinding.ts	0.00%	2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10472      +/-   ##
==========================================
- Coverage   81.93%   81.93%   -0.01%     
==========================================
  Files        1078     1078              
  Lines      107555   107555              
  Branches      733      733              
==========================================
- Hits        88125    88122       -3     
- Misses      19391    19394       +3     
  Partials       39       39              

Flag	Coverage Δ
editoast	74.38% <ø> (-0.01%)	⬇️
front	89.42% <0.00%> (ø)
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RomainValls]

I tried to reproduce the bug, by importing the trainSchedule. When i modify this train, i can see in itinerary that the unrecognized waypoint is marked in red (correct behavior). When I modify this train, and go back to its itinerary tab, I only see an "undefined" with no red and no error message.

[RomainValls]

Tested, it works, thanks for the fix 👍

[clarani]

Hum actually, this issue is more complex. It comes from the fact that the pathfinding is launched in setupItinerary, which does not handle the invalid items.
Adding this dependency in the useEffects will break the power restrictions, because the pathfinding will be launched twice: once in the hook useSetupItinerary and once in the usePathfinding hook (which will erase the power restrictions).

The best way to solve this bug would be to refacto the code so the pathfinding is launched only once when editing a train

[achrafmohye]

@clarani do you manage to reporduce the bug ?

[clarani]

The original bug must have been solved by #10696, it can't be reproduced now