front: revert part of #10371 #10474
Merged
front: revert part of #10371 #10474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khoyo
force-pushed
the
yk/revert-10371
branch
from
d0c26f7 to
136eec0
Compare
|
What is the motivation for this change? Ideally the commit message or GitHub PR description should explain. |
|
Indeed, this was opened fast to at least see if it has the desired effect :p |
anisometropie
approved these changes
Jan 21, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10474 +/- ##
==========================================
- Coverage 81.78% 81.77% -0.01%
==========================================
Files 1073 1073
Lines 106580 106574 -6
Branches 731 731
==========================================
- Hits 87166 87156 -10
- Misses 19375 19379 +4
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 0263825. Signed-off-by: Younes Khoudli <[email protected]>
This reverts commit 1fe0918. Signed-off-by: Younes Khoudli <[email protected]>
Khoyo
force-pushed
the
yk/revert-10371
branch
from
136eec0 to
d5369f8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert part of #10371 since it seems to make e2e tests flaky. We should investigate and follow up after.