docker: fix default network name in docker-compose.yml #10479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with specifying the project but can we keep the container names? Otherwise they get named eg. |
If omitted, the project name is automatically deduced from the parent directory name. This was working fine for container names because we were explicitly defining their names, but the network name was left unspecified. osrdyne default config depends on the network name being "osrd_default", but that wasn't the case when the parent directory wasn't named "osrd". Explicitly set the project name to fix this. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/docker-default-net-name
branch
from
fcfb1ee to
4c458d2
Compare
Oh, indeed! Dropped that change. |
Khoyo
approved these changes
Jan 22, 2025
woshilapin
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If omitted, the project name is automatically deduced from the parent directory name. This was working fine for container names because we were explicitly defining their names, but the network name was left unspecified. osrdyne default config depends on the network name being "osrd_default", but that wasn't the case when the parent directory wasn't named "osrd".
Explicitly set the project name to fix this. Drop explicit names for container names, since the default values should be fine now.