Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix cropped work schedule times #10483

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jan 22, 2025

Fixes #9793

@hamz2a hamz2a requested a review from a team as a code owner January 22, 2025 10:03
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (ec18e08) to head (592cbaf).
Report is 38 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10483      +/-   ##
==========================================
+ Coverage   81.78%   81.80%   +0.01%     
==========================================
  Files        1073     1073              
  Lines      106492   106584      +92     
  Branches      727      731       +4     
==========================================
+ Hits        87095    87191      +96     
+ Misses      19358    19354       -4     
  Partials       39       39              
Flag Coverage Δ
editoast 74.29% <100.00%> (+0.08%) ⬆️
front 89.34% <ø> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-fix-cropped-work-schedule-times branch from 883157f to 7c456a9 Compare January 22, 2025 10:44
@hamz2a hamz2a requested a review from a team as a code owner January 22, 2025 10:44
@hamz2a hamz2a requested a review from shenriotpro January 22, 2025 10:44
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Jan 22, 2025
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving since I'm not sure there is an easy solution to the small remark I made. I won't block the merge if we can't find an easy solution (I believe comment would be an ok solution).

@hamz2a hamz2a force-pushed the hai/editoast-fix-cropped-work-schedule-times branch from 7c456a9 to 878c6fc Compare January 22, 2025 10:52
@hamz2a hamz2a force-pushed the hai/editoast-fix-cropped-work-schedule-times branch from 878c6fc to 592cbaf Compare January 22, 2025 11:00
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tests/

@hamz2a hamz2a added this pull request to the merge queue Jan 22, 2025
Merged via the queue into dev with commit 8d71c73 Jan 22, 2025
27 checks passed
@hamz2a hamz2a deleted the hai/editoast-fix-cropped-work-schedule-times branch January 22, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work schedules start and end time seem cropped by the stdcm research window
4 participants