Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timetable performance #10489

Merged
merged 2 commits into from
Feb 10, 2025
Merged

timetable performance #10489

merged 2 commits into from
Feb 10, 2025

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Jan 22, 2025

e2e have been stabilized (ran OK 10 times) reintroduce performances gains from #10371

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 22, 2025
@anisometropie anisometropie changed the base branch from dev to aba/e2e-fix-flaky-e2e-test-008 January 22, 2025 21:05
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (42f1939) to head (85c06fa).
Report is 6 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10489      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.01%     
==========================================
  Files        1078     1078              
  Lines      107544   107550       +6     
  Branches      733      733              
==========================================
- Hits        88114    88110       -4     
- Misses      19391    19401      +10     
  Partials       39       39              
Flag Coverage Δ
editoast 74.36% <ø> (-0.04%) ⬇️
front 89.42% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anisometropie anisometropie force-pushed the aba/e2e-fix-flaky-e2e-test-008 branch from 2634e9e to 08c13fb Compare January 28, 2025 16:20
@Maymanaf Maymanaf force-pushed the aba/e2e-fix-flaky-e2e-test-008 branch 2 times, most recently from 92d65e8 to 2b1016c Compare February 5, 2025 10:36
@anisometropie anisometropie force-pushed the vcs/008 branch 3 times, most recently from 199aa27 to 82c5398 Compare February 5, 2025 15:27
@anisometropie anisometropie changed the base branch from aba/e2e-fix-flaky-e2e-test-008 to dev February 5, 2025 15:27
@anisometropie anisometropie changed the title flaky e2e-008 timetable performance Feb 7, 2025
@anisometropie anisometropie marked this pull request as ready for review February 7, 2025 09:33
@anisometropie anisometropie requested a review from a team as a code owner February 7, 2025 09:33
@Maymanaf Maymanaf self-requested a review February 7, 2025 11:32
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This reverts commit c4827a5.

Signed-off-by: Valentin Chanas <[email protected]>
This reverts commit d5369f8.

Signed-off-by: Valentin Chanas <[email protected]>
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@anisometropie anisometropie added this pull request to the merge queue Feb 10, 2025
Merged via the queue into dev with commit 7a08098 Feb 10, 2025
27 checks passed
@anisometropie anisometropie deleted the vcs/008 branch February 10, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants