Fix incorrect input saving when switching simulations during a running calculation #10497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmer2016
requested review from
theocrsb,
SharglutDev and
RomainValls
and removed request for
theocrsb
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10497 +/- ##
==========================================
- Coverage 81.93% 81.87% -0.07%
==========================================
Files 1083 1083
Lines 107554 107249 -305
Branches 741 738 -3
==========================================
- Hits 88124 87805 -319
- Misses 19389 19403 +14
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
cf10bc1 to
d4cca27
Compare
SharglutDev
reviewed
Jan 23, 2025
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
d4cca27 to
8016bc4
Compare
RomainValls
approved these changes
Jan 24, 2025
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
3 times, most recently
from
aeaf7ba to
495a832
Compare
SharglutDev
reviewed
Feb 6, 2025
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
3 times, most recently
from
fba5713 to
3b7c890
Compare
SharglutDev
reviewed
Feb 11, 2025
SharglutDev
reviewed
Feb 11, 2025
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
3b7c890 to
321ed89
Compare
SharglutDev
reviewed
Feb 12, 2025
front/src/reducers/osrdconf/stdcmConf/stdcmConfReducers.spec.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmForm/StdcmConfig.tsx
Outdated
Show resolved
Hide resolved
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
321ed89 to
8fec411
Compare
SharglutDev
approved these changes
Feb 14, 2025
… running calculation When a different simulation is selected while a calculation is still running, the new simulation’s inputs overwrite the inputs of the ongoing calculation. This causes a mismatch between the inputs used for the calculation and the results. To maintain a good UX, the following improvements have been made: - prevent display pathfinding status message when change the current simulation - prevent visual jump on current simulation change - prevent animation after switching simulation and clearing a via input Signed-off-by: nncluzu <[email protected]>
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
8078da8 to
a2b621a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10480
When a different simulation is selected while a calculation is still running, the new simulation’s inputs overwrite the inputs of the ongoing calculation. This causes a mismatch between the inputs used for the calculation and the results.