Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix typo in initFixedPoints, with unit test #10498

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jan 23, 2025

While trying to reproduce the bug seen in #10488, I ended up with a unit test that failed, which led me to this typo (introduced in the previous PR)

@eckter eckter requested a review from Erashin January 23, 2025 10:13
@eckter eckter requested a review from a team as a code owner January 23, 2025 10:13
@github-actions github-actions bot added the area:core Work on Core Service label Jan 23, 2025
@eckter eckter enabled auto-merge January 23, 2025 10:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (f0a5c8e) to head (506c15e).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10498      +/-   ##
==========================================
- Coverage   81.80%   81.80%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106601   106606       +5     
  Branches      731      731              
==========================================
  Hits        87209    87209              
- Misses      19353    19358       +5     
  Partials       39       39              
Flag Coverage Δ
editoast 74.28% <ø> (-0.02%) ⬇️
front 89.34% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@eckter eckter added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit 5bd1d85 Jan 23, 2025
27 checks passed
@eckter eckter deleted the ech/fix-typo-points branch January 23, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants