Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: optimize batch simulation for stdcm #10500

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Jan 23, 2025

@younesschrifi younesschrifi requested a review from a team as a code owner January 23, 2025 10:57
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 23, 2025
@younesschrifi younesschrifi changed the title Yci/optimize batch simulation for stdcm editoast: optimize batch simulation for stdcm Jan 23, 2025
@younesschrifi younesschrifi force-pushed the yci/optimize_batch_simulation_for_stdcm branch from 6ff4afe to 7d490a9 Compare January 23, 2025 10:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.24299% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (3985a9e) to head (c405ea8).
Report is 25 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/train_schedule.rs 83.07% 11 Missing ⚠️
editoast/src/views/path/pathfinding.rs 80.95% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10500      +/-   ##
==========================================
+ Coverage   81.78%   81.80%   +0.02%     
==========================================
  Files        1073     1073              
  Lines      106578   106716     +138     
  Branches      731      730       -1     
==========================================
+ Hits        87164    87299     +135     
- Misses      19375    19378       +3     
  Partials       39       39              
Flag Coverage Δ
editoast 74.27% <82.24%> (+0.05%) ⬆️
front 89.34% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@younesschrifi younesschrifi force-pushed the yci/optimize_batch_simulation_for_stdcm branch from 7d490a9 to c405ea8 Compare January 23, 2025 11:23
@flomonster flomonster added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit 95eb29e Jan 23, 2025
27 checks passed
@flomonster flomonster deleted the yci/optimize_batch_simulation_for_stdcm branch January 23, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants