Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: rename and invert authorization flag for consistency #10509

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jan 23, 2025

Renames disable_authorization to enable_authorization and inverts its logic for better clarity.

@hamz2a hamz2a requested a review from a team as a code owner January 23, 2025 14:54
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 23, 2025
@hamz2a hamz2a force-pushed the hai/editoast-refactor-enable-authorization-flag branch from 33ce864 to 1f8efc4 Compare January 23, 2025 14:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (d651580) to head (d4cb9a2).
Report is 17 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/client/runserver.rs 0.00% 4 Missing ⚠️
editoast/src/views/mod.rs 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##              dev   #10509    +/-   ##
========================================
  Coverage   81.80%   81.80%            
========================================
  Files        1073     1073            
  Lines      106604   106718   +114     
  Branches      730      730            
========================================
+ Hits        87208    87304    +96     
- Misses      19357    19375    +18     
  Partials       39       39            
Flag Coverage Δ
editoast 74.28% <40.00%> (-0.02%) ⬇️
front 89.34% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a self-assigned this Jan 23, 2025
@hamz2a hamz2a added the kind:refacto-task Task related to Refactorization Epic label Jan 23, 2025
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but useful improvement. Thank you.

@hamz2a hamz2a force-pushed the hai/editoast-refactor-enable-authorization-flag branch from 1f8efc4 to d4cb9a2 Compare January 24, 2025 13:58
@hamz2a hamz2a added this pull request to the merge queue Jan 24, 2025
Merged via the queue into dev with commit 9314f35 Jan 24, 2025
27 checks passed
@hamz2a hamz2a deleted the hai/editoast-refactor-enable-authorization-flag branch January 24, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants