front: get correct coordinates of uic pathsteps #10515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10515 +/- ##
==========================================
+ Coverage 81.83% 81.89% +0.05%
==========================================
Files 1073 1076 +3
Lines 107058 107182 +124
Branches 728 729 +1
==========================================
+ Hits 87613 87776 +163
+ Misses 19406 19367 -39
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
force-pushed
the
cni/8901-uic-waypoint-not-correctly-displayed-on-the-map
branch
2 times, most recently
from
848a054 to
3d2b43f
Compare
clarani
changed the title
clarani
force-pushed
the
cni/8901-uic-waypoint-not-correctly-displayed-on-the-map
branch
from
3d2b43f to
a4e7d41
Compare
SharglutDev
reviewed
Jan 27, 2025
front/src/modules/pathfinding/helpers/getTrackLengthCumulativeSums.ts
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/helpers/findTrackSectionOffset.ts
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/helpers/__tests__/findTrackSectionOffset.ts
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/helpers/__tests__/findTrackSectionOffset.ts
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/helpers/getPointOnPathCoordinates.ts
Outdated
Show resolved
Hide resolved
|
Lgtm and tested ! You can fix the remaining comments and conflicts and I'll give it another testing before approve when you're done :) |
clarani
force-pushed
the
cni/8901-uic-waypoint-not-correctly-displayed-on-the-map
branch
from
0ffdeaa to
f15d5b6
Compare
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/8901-uic-waypoint-not-correctly-displayed-on-the-map
branch
from
f15d5b6 to
7bdd97e
Compare
Synar
approved these changes
Feb 3, 2025
front/src/modules/pathfinding/helpers/getPointOnPathCoordinates.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
…utils Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/8901-uic-waypoint-not-correctly-displayed-on-the-map
branch
from
7bdd97e to
0a33b13
Compare
SharglutDev
approved these changes
Feb 3, 2025
clarani
deleted the
cni/8901-uic-waypoint-not-correctly-displayed-on-the-map
branch
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8901
See commits
The markers were not correctly placed because the calculations were wrong: we could not use a simple rule of three to find the correct point in the path geometry.