Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix api and network errors not being caught and displayed in infra editor #10516

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Jan 23, 2025

Close #10514

@Synar Synar requested a review from a team as a code owner January 23, 2025 17:29
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (2950b2f) to head (2486feb).
Report is 69 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10516      +/-   ##
==========================================
+ Coverage   81.78%   81.82%   +0.03%     
==========================================
  Files        1073     1073              
  Lines      106577   106805     +228     
  Branches      731      730       -1     
==========================================
+ Hits        87162    87388     +226     
- Misses      19376    19378       +2     
  Partials       39       39              
Flag Coverage Δ
editoast 74.29% <ø> (+0.06%) ⬆️
front 89.34% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar Synar requested a review from a team as a code owner January 27, 2025 21:31
@Synar Synar force-pushed the ali/fix-silent-error-in-infra-deletion branch from b1711bf to 2486feb Compare January 27, 2025 21:32
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job :)

@Maymanaf Maymanaf removed the request for review from a team January 31, 2025 12:57
@Synar Synar added this pull request to the merge queue Jan 31, 2025
Merged via the queue into dev with commit 79ce74c Jan 31, 2025
27 checks passed
@Synar Synar deleted the ali/fix-silent-error-in-infra-deletion branch January 31, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: infrastructure deletion fails silently with a success message
3 participants