Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: improve tools to log and reproduce requests #10522

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jan 24, 2025

We already had an env variable to write STDCM payloads to files, and a cli command to rerun such payload. This PR adds the same things for pathfinding and simulation requests.

@eckter eckter requested a review from Erashin January 24, 2025 13:23
@eckter eckter requested a review from a team as a code owner January 24, 2025 13:23
@github-actions github-actions bot added the area:core Work on Core Service label Jan 24, 2025
@eckter eckter force-pushed the ech/improve-core-reproducing branch from d7ea85e to a7e5c58 Compare January 24, 2025 13:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (1fe7f70) to head (a7e5c58).
Report is 32 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10522      +/-   ##
==========================================
- Coverage   81.81%   81.80%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106718   106718              
  Branches      730      730              
==========================================
- Hits        87307    87300       -7     
- Misses      19372    19379       +7     
  Partials       39       39              
Flag Coverage Δ
editoast 74.27% <ø> (-0.03%) ⬇️
front 89.34% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter marked this pull request as draft January 27, 2025 16:09
@eckter eckter marked this pull request as ready for review January 27, 2025 16:10
@eckter eckter added this pull request to the merge queue Jan 29, 2025
Merged via the queue into dev with commit ecb261f Jan 29, 2025
27 checks passed
@eckter eckter deleted the ech/improve-core-reproducing branch January 29, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants