remove react css transition #10523
Merged
remove react css transition #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10523 +/- ##
==========================================
- Coverage 81.85% 81.83% -0.02%
==========================================
Files 1075 1073 -2
Lines 107153 107058 -95
Branches 728 728
==========================================
- Hits 87708 87610 -98
- Misses 19406 19409 +3
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
force-pushed
the
pfn/front/remove-react-css-transition
branch
from
cd2debb to
5e90eac
Compare
kmer2016
approved these changes
Jan 31, 2025
This library didn't have a new release since 2022. It uses a react tool that will be deprecated in react v19 (findDOMNode). It was used to display tooltips when hovering some buttons in the app. Since the design system doesn't have a custom tooltip for buttons, it has been requested to just use the regular title html attribute. Instead of finding a substitute lib, just remove the old one and use the title attribute. Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
pfn/front/remove-react-css-transition
branch
from
5e90eac to
bad24fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits
Remove react-ccs-transition lib for buttons tooltip in favor of
titlehtml attribute (validated by @thibautsailly).In the future, if the design system requires some custom tooltip, we can use the native popover api and anchor api (when it goes available on firefox).
fix #9595
fix #10524
To test :