-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress editoast cached data #10527
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10527 +/- ##
========================================
Coverage 81.81% 81.81%
========================================
Files 1073 1073
Lines 106718 106981 +263
Branches 730 728 -2
========================================
+ Hits 87307 87528 +221
- Misses 19372 19414 +42
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4f38679
to
27b1545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopes this improve what we're looking for. Do you have some numbers? It would be nice to put them in the description so future us can find these when reevaluating the situation.
8ce4d41
to
ec3675f
Compare
We're benchmarking PR. I will add numbers in live :) |
c268b81
to
35c9cf4
Compare
Wouldn't reducing the batch size improve the performances since transport is likely the limiting factor here? |
We can merge this PR. We've made a slight improvement. The result is not very visible because of other problems I've listed here. |
Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
35c9cf4
to
b0edd25
Compare
The json request and response from the pathfinding and the simulation take too much time to be get from valkey or push in valkey. The solution is to use gzip to compress the payloads.
Benchmarks
All benchmark were run on dev.
No compression (
BATCH_SIZE=500
)Zstd -1 (
BATCH_SIZE=500
)LZ4 -1 (
BATCH_SIZE=500
)