Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: in LoA case, add maintain curve to indication curve before finding intersection with overlay envelope #10528

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Jan 27, 2025

Fixes #10443.

@Erashin Erashin added the area:core Work on Core Service label Jan 27, 2025
@Erashin Erashin requested a review from a team as a code owner January 27, 2025 11:03
@Erashin Erashin requested review from eckter and bougue-pe January 27, 2025 11:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (4ddefb0) to head (d187915).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10528   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files        1076     1076           
  Lines      107583   107583           
  Branches      731      731           
=======================================
  Hits        88156    88156           
  Misses      19388    19388           
  Partials       39       39           
Flag Coverage Δ
editoast 74.32% <ø> (ø)
front 89.46% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/core/loa_maintain_curve_bug branch from c8fc0d7 to 7488983 Compare January 27, 2025 13:33
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need some testing on those cases at some point (unit would be better, could be integration).
Anyway, this patch is fine 👍

Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(You'll need to rebase after some other work on dev branch)

@Erashin Erashin force-pushed the alch/core/loa_maintain_curve_bug branch from dc70820 to bcc21db Compare February 10, 2025 13:13
@Erashin Erashin enabled auto-merge February 11, 2025 13:45
…ing intersection with overlay envelope

Signed-off-by: Erashin <[email protected]>
@Erashin Erashin force-pushed the alch/core/loa_maintain_curve_bug branch from bcc21db to d187915 Compare February 11, 2025 13:50
@Erashin Erashin added this pull request to the merge queue Feb 11, 2025
Merged via the queue into dev with commit d187915 Feb 11, 2025
53 checks passed
@Erashin Erashin deleted the alch/core/loa_maintain_curve_bug branch February 11, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: etcs: loa bug: add maintain curve to indication curve before calling keepBrakingCurverUnderOverlay
4 participants