Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: carry over script changes to readmes #10530

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

bougue-pe
Copy link
Contributor

@bougue-pe bougue-pe commented Jan 27, 2025

Just update readmes after current work on script (targeting the 🚧-branch)
If it's easier to just pick the commit to avoid multiple reviews, please do (and close this).

TODO:

  • add a mention to no-cache option for editoast

@bougue-pe bougue-pe requested review from a team as code owners January 27, 2025 14:20
@bougue-pe bougue-pe requested review from eckter and ElysaSrc January 27, 2025 14:20
@github-actions github-actions bot added area:core Work on Core Service area:front Work on Standard OSRD Interface modules area:gateway labels Jan 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (018833a) to head (7d84992).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10530   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files        1079     1079           
  Lines      107233   107233           
  Branches      729      729           
=======================================
  Hits        87839    87839           
  Misses      19354    19354           
  Partials       40       40           
Flag Coverage Δ
editoast 74.21% <ø> (ø)
front 89.46% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To merge after the merging of the script

@bougue-pe bougue-pe changed the title doc: report script changes to readmes doc: carry over script changes to readmes Jan 27, 2025
@ElysaSrc ElysaSrc force-pushed the ev/trash-nginx-front-devenv branch 2 times, most recently from 5623b9b to fe1b2d6 Compare January 31, 2025 15:48
@bougue-pe bougue-pe force-pushed the peb/improve_doc_devenv_scripts branch from 0395253 to 3e4c266 Compare January 31, 2025 16:16
@bougue-pe bougue-pe requested a review from a team as a code owner January 31, 2025 18:02
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 31, 2025
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ElysaSrc ElysaSrc force-pushed the ev/trash-nginx-front-devenv branch from fe1b2d6 to 488354a Compare February 4, 2025 08:55
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bougue-pe bougue-pe force-pushed the peb/improve_doc_devenv_scripts branch 2 times, most recently from e8cb884 to 50c2fbe Compare February 4, 2025 15:17
@bougue-pe bougue-pe requested a review from clarani February 4, 2025 15:25
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElysaSrc ElysaSrc force-pushed the ev/trash-nginx-front-devenv branch from 488354a to 864e740 Compare February 5, 2025 12:57
@ElysaSrc ElysaSrc requested review from a team as code owners February 5, 2025 12:57
@ElysaSrc ElysaSrc requested review from bloussou and removed request for a team February 5, 2025 12:57
@ElysaSrc ElysaSrc force-pushed the ev/trash-nginx-front-devenv branch from 864e740 to 1767027 Compare February 5, 2025 12:59
@bougue-pe bougue-pe force-pushed the peb/improve_doc_devenv_scripts branch from 50c2fbe to 103746f Compare February 5, 2025 13:06
@bougue-pe bougue-pe removed request for a team and bloussou February 5, 2025 13:06
@ElysaSrc ElysaSrc force-pushed the ev/trash-nginx-front-devenv branch from 1767027 to 4c75436 Compare February 5, 2025 14:00
Base automatically changed from ev/trash-nginx-front-devenv to dev February 5, 2025 18:05
@ElysaSrc ElysaSrc force-pushed the peb/improve_doc_devenv_scripts branch from 103746f to 7d84992 Compare February 5, 2025 18:35
@ElysaSrc ElysaSrc enabled auto-merge February 5, 2025 18:36
@ElysaSrc ElysaSrc added this pull request to the merge queue Feb 5, 2025
Merged via the queue into dev with commit 716e6c8 Feb 5, 2025
27 checks passed
@ElysaSrc ElysaSrc deleted the peb/improve_doc_devenv_scripts branch February 5, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:gateway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants