editoast: force 'otel::tracing=info' for some tests #10531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10531 +/- ##
=======================================
Coverage 81.90% 81.90%
=======================================
Files 1079 1079
Lines 107473 107487 +14
Branches 734 734
=======================================
+ Hits 88024 88037 +13
- Misses 19409 19410 +1
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bougue-pe
reviewed
Jan 27, 2025
bougue-pe
approved these changes
Jan 27, 2025
leovalais
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
I think I like this proposition better.
- Keeping the ability to configure
RUST_LOGfor running tests is useful (to me at least). - Tests that require a specific log directives will be emphasized and show explicitly which directives affects the behavior of the tested feature.
Khoyo
reviewed
Jan 27, 2025
woshilapin
changed the title
woshilapin
force-pushed
the
wsl/editoast/force-otel-span-for-tests
branch
from
fa48f4c to
ff2acc0
Compare
|
Since #10526 has been abandoned in favor of the current PR, let's merge it? |
The STDCM log feature depends on Opentelemetry span being created in the Axum middleware. If `RUST_LOG=warn`, tests will fail because no span is created and therefore no trace ID is created and tests depends on this trace ID. The added directives are applied after reading `RUST_LOG`. Signed-off-by: Jean SIMARD <[email protected]>
woshilapin
force-pushed
the
wsl/editoast/force-otel-span-for-tests
branch
from
ff2acc0 to
9d7bcfc
Compare
bougue-pe
reviewed
Feb 7, 2025
Signed-off-by: Jean SIMARD <[email protected]>
woshilapin
force-pushed
the
wsl/editoast/force-otel-span-for-tests
branch
from
9d7bcfc to
4eeec9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STDCM log feature depends on Opentelemetry span being created in the Axum middleware. If
RUST_LOG=warn, tests will fail because no span is created and therefore no trace ID is created and tests depends on this trace ID.The added directives are applied after reading
RUST_LOG.This is an alternative solution to what was proposed in #10526.