Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add .zed to .gitignore #10557

Merged
merged 1 commit into from
Feb 4, 2025
Merged

misc: add .zed to .gitignore #10557

merged 1 commit into from
Feb 4, 2025

Conversation

leovalais
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (892a5a6) to head (59635b6).
Report is 46 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10557      +/-   ##
==========================================
- Coverage   81.87%   81.87%   -0.01%     
==========================================
  Files        1074     1074              
  Lines      107132   107132              
  Branches      728      728              
==========================================
- Hits        87712    87709       -3     
- Misses      19381    19384       +3     
  Partials       39       39              
Flag Coverage Δ
editoast 74.28% <ø> (-0.01%) ⬇️
front 89.38% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

In general I don't like adding lists of editors in .gitignore, I recommend setting up a global ignore instead: https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

The reason is that this doesn't scale: each project needs to add each text editor and keep up with new editors.

But I see there are other editors in there already…

@leovalais
Copy link
Contributor Author

I'd agree, that's why I didn't push this sooner. But since others are here and that there's a bunch of us using zed already, why not? 🤷

I'm completely fine with removing all editors config as well, but consistency and all :)

@leovalais leovalais requested a review from flomonster January 31, 2025 12:10
@leovalais leovalais added this pull request to the merge queue Feb 4, 2025
Merged via the queue into dev with commit 98b012c Feb 4, 2025
27 checks passed
@leovalais leovalais deleted the lva/ignore-zed branch February 4, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants