Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add some variables to stdcm store #10603

Merged
merged 4 commits into from
Feb 6, 2025
Merged

front: add some variables to stdcm store #10603

merged 4 commits into from
Feb 6, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 31, 2025

closes #10600

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 31, 2025
@clarani clarani force-pushed the cni/10600-add-stdcm-simulations-to-store branch from a058356 to 19adf92 Compare January 31, 2025 12:23
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (716e6c8) to head (320a2c1).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #10603   +/-   ##
=======================================
  Coverage   81.91%   81.92%           
=======================================
  Files        1079     1079           
  Lines      107233   107274   +41     
  Branches      729      737    +8     
=======================================
+ Hits        87840    87880   +40     
- Misses      19353    19354    +1     
  Partials       40       40
Flag Coverage Δ
editoast 74.20% <ø> (-0.01%) ⬇️
front 89.47% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/10600-add-stdcm-simulations-to-store branch 2 times, most recently from 0a5c454 to 524929c Compare January 31, 2025 15:13
@clarani clarani marked this pull request as ready for review January 31, 2025 15:37
@clarani clarani requested a review from a team as a code owner January 31, 2025 15:37
SharglutDev
SharglutDev reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refacto !

I have one bug : white screen when clicking on new query with current input button

kmer2016
kmer2016 reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I made some propositions

achrafmohye
achrafmohye approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refacto, LGTM and tested :)

kmer2016
kmer2016 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you forr the refacto and test ! ;)

SharglutDev
SharglutDev approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@clarani
front: add stdcm simulations to store
d897b0b 
Signed-off-by: Clara Ni <[email protected]>
@clarani
front: add retainSimulationIndex to stdcm store
224aefc 
Signed-off-by: Clara Ni <[email protected]>
@clarani
front: add selectedSimulation to stdcm store
1319364 
Signed-off-by: Clara Ni <[email protected]>
@clarani
front: remove updateStdcmConfigWithData action
320a2c1 
updateStdcmConfigWithData was used to update the form fields when the selected simulation changed.
The fields can actually be updated in the same action which modifies the selected simulation.

Signed-off-by: Clara Ni <[email protected]>
@clarani clarani force-pushed the cni/10600-add-stdcm-simulations-to-store branch from d7d9b4d to 320a2c1 Compare February 6, 2025 11:54
@clarani clarani enabled auto-merge February 6, 2025 11:55
@clarani clarani added this pull request to the merge queue Feb 6, 2025
Merged via the queue into dev with commit 9f2a3bf Feb 6, 2025
27 checks passed
@clarani clarani deleted the cni/10600-add-stdcm-simulations-to-store branch February 6, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

@achrafmohye achrafmohye achrafmohye approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

@SarahBellaha SarahBellaha Awaiting requested review from SarahBellaha

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: add stdcm simulations to the store
5 participants
@clarani @codecov-commenter @kmer2016 @achrafmohye @SharglutDev