-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support models with a single primary key in Model derive macro #10620
Conversation
Signed-off-by: Leo Valais <[email protected]>
72fb125
to
53334a0
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10620 +/- ##
==========================================
+ Coverage 81.83% 81.93% +0.09%
==========================================
Files 1073 1079 +6
Lines 107058 107380 +322
Branches 728 737 +9
==========================================
+ Hits 87613 87977 +364
+ Misses 19406 19363 -43
- Partials 39 40 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
808db22
to
ef83c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! Sorry for the delay of the review. A few comments made mostly by you 😛
Bonus: 2887807 |
Signed-off-by: Leo Valais <[email protected]>
Signed-off-by: Leo Valais <[email protected]>
Signed-off-by: Leo Valais <[email protected]>
2887807
to
66fe81e
Compare
closes #8111