Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support models with a single primary key in Model derive macro #10620

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

leovalais
Copy link
Contributor

closes #8111

@leovalais leovalais requested a review from a team as a code owner February 2, 2025 18:34
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 2, 2025
@leovalais leovalais force-pushed the lva/single-pk-models branch from 72fb125 to 53334a0 Compare February 2, 2025 18:35
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.66019% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (586b13c) to head (66fe81e).
Report is 76 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/editoast_derive/src/model/parsing.rs 93.26% 7 Missing ⚠️
editoast/src/client/timetables_commands.rs 0.00% 3 Missing ⚠️
editoast/editoast_derive/src/model/args.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10620      +/-   ##
==========================================
+ Coverage   81.83%   81.93%   +0.09%     
==========================================
  Files        1073     1079       +6     
  Lines      107058   107380     +322     
  Branches      728      737       +9     
==========================================
+ Hits        87613    87977     +364     
+ Misses      19406    19363      -43     
- Partials       39       40       +1     
Flag Coverage Δ
editoast 74.26% <94.66%> (+0.01%) ⬆️
front 89.47% <ø> (+0.10%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/single-pk-models branch 2 times, most recently from 808db22 to ef83c62 Compare February 3, 2025 15:02
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Sorry for the delay of the review. A few comments made mostly by you 😛

@leovalais
Copy link
Contributor Author

Bonus: 2887807

@leovalais leovalais requested a review from woshilapin February 6, 2025 14:11
@leovalais leovalais force-pushed the lva/single-pk-models branch from 2887807 to 66fe81e Compare February 6, 2025 14:34
@leovalais leovalais enabled auto-merge February 6, 2025 14:34
@leovalais leovalais added this pull request to the merge queue Feb 6, 2025
Merged via the queue into dev with commit b3a6f01 Feb 6, 2025
27 checks passed
@leovalais leovalais deleted the lva/single-pk-models branch February 6, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement support for single PK field in ModelV2
5 participants