-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix track selection after timestops changes #10624
front: fix track selection after timestops changes #10624
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10624 +/- ##
==========================================
- Coverage 81.93% 81.93% -0.01%
==========================================
Files 1078 1078
Lines 107555 107560 +5
Branches 733 733
==========================================
+ Hits 88125 88126 +1
- Misses 19391 19395 +4
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@RomainValls when i add a stop time i still have v2 and not V1BIS that i made as the track for the train stop in Macon, is it the case or am i missing something ? |
b4df02d
to
2f34ad2
Compare
I tried again, and it seems fixed for me : Enregistrement.de.l.ecran.2025-02-06.a.18.07.40.movI also tried other tracks, and by editing the timestop after I added the train first, and edited it after. |
2f34ad2
to
51830ac
Compare
Signed-off-by: romainvalls <[email protected]>
51830ac
to
5c43382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, it's good for me now, i think you can add a todo if the fix regarding the types proposed by @Synar to be done by someone else in a seperate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ! And agreed with @achrafmohye, you shall create a new issue to do the suggestion made by @Synar
Created this issue for the typecast : #10805 |
Closes #10532