Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix track selection after timestops changes #10624

Merged

Conversation

RomainValls
Copy link
Contributor

Closes #10532

@RomainValls RomainValls requested a review from a team as a code owner February 3, 2025 10:55
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 3, 2025
@RomainValls RomainValls self-assigned this Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (eeb8aa2) to head (5c43382).
Report is 68 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10624      +/-   ##
==========================================
- Coverage   81.93%   81.93%   -0.01%     
==========================================
  Files        1078     1078              
  Lines      107555   107560       +5     
  Branches      733      733              
==========================================
+ Hits        88125    88126       +1     
- Misses      19391    19395       +4     
  Partials       39       39              
Flag Coverage Δ
editoast 74.38% <ø> (-0.02%) ⬇️
front 89.42% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achrafmohye
Copy link
Contributor

@RomainValls when i add a stop time i still have v2 and not V1BIS that i made as the track for the train stop in Macon, is it the case or am i missing something ?

@RomainValls RomainValls force-pushed the rvs/front-fix-track-selection-after-timestops-changes branch from b4df02d to 2f34ad2 Compare February 6, 2025 15:54
@RomainValls
Copy link
Contributor Author

@RomainValls when i add a stop time i still have v2 and not V1BIS that i made as the track for the train stop in Macon, is it the case or am i missing something ?

I tried again, and it seems fixed for me :

Enregistrement.de.l.ecran.2025-02-06.a.18.07.40.mov

I also tried other tracks, and by editing the timestop after I added the train first, and edited it after.
@Math-R what about you ?

@RomainValls RomainValls force-pushed the rvs/front-fix-track-selection-after-timestops-changes branch from 2f34ad2 to 51830ac Compare February 7, 2025 14:28
@RomainValls RomainValls force-pushed the rvs/front-fix-track-selection-after-timestops-changes branch from 51830ac to 5c43382 Compare February 10, 2025 12:51
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, it's good for me now, i think you can add a todo if the fix regarding the types proposed by @Synar to be done by someone else in a seperate PR

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! And agreed with @achrafmohye, you shall create a new issue to do the suggestion made by @Synar

@RomainValls RomainValls added this pull request to the merge queue Feb 14, 2025
@RomainValls
Copy link
Contributor Author

Created this issue for the typecast : #10805

Merged via the queue into dev with commit d1d32ae Feb 14, 2025
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-track-selection-after-timestops-changes branch February 14, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track choice erased when adding a stopping time
5 participants