Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: spacetimechart: fix drag behaviour when draging train to the left #10625

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Feb 3, 2025

close #10511

Previously when you were dragging the earliest train to the left, the spaceTimeChart window was sliding to the left.
Now the SpaceTimeChart window won't move anymore unless you stop the train drag and pan the window

@Math-R Math-R requested a review from a team as a code owner February 3, 2025 11:25
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 3, 2025
@Math-R Math-R requested review from kmer2016, SharglutDev and SarahBellaha and removed request for SharglutDev February 3, 2025 11:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (ecb261f) to head (71577b9).
Report is 50 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10625      +/-   ##
==========================================
- Coverage   81.85%   81.83%   -0.02%     
==========================================
  Files        1075     1073       -2     
  Lines      107172   107078      -94     
  Branches      728      728              
==========================================
- Hits        87726    87630      -96     
- Misses      19407    19409       +2     
  Partials       39       39              
Flag Coverage Δ
editoast 74.24% <ø> (-0.01%) ⬇️
front 89.37% <100.00%> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev requested a review from Akctarus February 4, 2025 08:57
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kmer2016 kmer2016 added this pull request to the merge queue Feb 4, 2025
Merged via the queue into dev with commit 8a9f218 Feb 4, 2025
27 checks passed
@kmer2016 kmer2016 deleted the mrd/fix-drag-behaviour branch February 4, 2025 17:01
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop updating the time window when moving a train around in the GET
5 participants