Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix spacetimechart redraw after waypoint visibility change #10626

Conversation

RomainValls
Copy link
Contributor

closes #10609

I'm not sure if we should fix this in osrd or osrd-ui ?

@RomainValls RomainValls requested a review from a team as a code owner February 3, 2025 14:18
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 3, 2025
@RomainValls RomainValls requested review from Yohh and clarani February 3, 2025 14:18
@RomainValls RomainValls self-assigned this Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (586b13c) to head (b485444).
Report is 296 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10626      +/-   ##
==========================================
- Coverage   81.83%   81.76%   -0.08%     
==========================================
  Files        1073     1055      -18     
  Lines      107058   106000    -1058     
  Branches      728      722       -6     
==========================================
- Hits        87613    86667     -946     
+ Misses      19406    19294     -112     
  Partials       39       39              
Flag Coverage Δ
editoast 74.18% <ø> (-0.07%) ⬇️
front 89.36% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like an osrd-ui bug. Forcing a redraw is a workaround IMHO.

@clarani
Copy link
Contributor

clarani commented Feb 4, 2025

Agree with @emersion, it would be better to fix this in osrd-ui.

Here is the expected workflow:

  • hiding a PR => should trigger the hook useManchetteWithSpaceTimeChart
  • useManchetteWithSpaceTimeChart gives a new list of PRs => should trigger the redrawn of the GET

@clarani clarani removed their request for review February 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET : Hiding a PR does not erase the associated horizontal line
4 participants