Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: adapt timetable endpoint and delete post endpoint #10655

Merged
merged 1 commit into from
Feb 20, 2025
Merged

editoast: adapt timetable endpoint and delete post endpoint #10655

merged 1 commit into from
Feb 20, 2025

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Feb 3, 2025 •
edited
Loading

close #10656

@younesschrifi younesschrifi requested a review from a team as a code owner February 3, 2025 20:22
@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service labels Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.77193% with 37 lines in your changes missing coverage. Please review.

Project coverage is 82.57%. Comparing base (6edea6d) to head (a84f037).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/common/api/osrdEditoastApi.ts 78.57% 30 Missing ⚠️
front/src/common/api/generatedEditoastApi.ts 46.15% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10655      +/-   ##
==========================================
- Coverage   82.60%   82.57%   -0.04%     
==========================================
  Files        1084     1084              
  Lines      107444   107404      -40     
  Branches      729      730       +1     
==========================================
- Hits        88757    88684      -73     
- Misses      18645    18678      +33     
  Partials       42       42
Flag Coverage Δ
editoast 74.38% <100.00%> (-0.04%) ⬇️
front 90.47% <82.12%> (-0.05%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/adapt_timetable_endpoints branch from 925a228 to c58e8bb Compare February 4, 2025 14:40
leovalais
leovalais reviewed Feb 4, 2025
View reviewed changes
@younesschrifi younesschrifi force-pushed the yci/adapt_timetable_endpoints branch from c58e8bb to 498e995 Compare February 4, 2025 23:00
woshilapin
woshilapin reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be missing something about the new endpoint?

@younesschrifi younesschrifi force-pushed the yci/adapt_timetable_endpoints branch from 498e995 to b847d90 Compare February 5, 2025 09:42
@younesschrifi younesschrifi requested a review from a team as a code owner February 5, 2025 09:42
@younesschrifi younesschrifi force-pushed the yci/adapt_timetable_endpoints branch 4 times, most recently from 2858fec to 9dc58ce Compare February 6, 2025 09:14
@younesschrifi younesschrifi requested a review from a team as a code owner February 6, 2025 09:14
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Feb 6, 2025
leovalais
leovalais reviewed Feb 7, 2025
View reviewed changes
@younesschrifi younesschrifi force-pushed the yci/adapt_timetable_endpoints branch 4 times, most recently from 500bdcb to f6077bf Compare February 10, 2025 00:58
@Wadjetz Wadjetz requested a review from emersion February 18, 2025 12:20
@younesschrifi younesschrifi requested review from Maymanaf and shenriotpro and removed request for bloussou February 18, 2025 12:48
shenriotpro
shenriotpro approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tests/

@Wadjetz Wadjetz force-pushed the yci/adapt_timetable_endpoints branch from 62d48db to e36278a Compare February 19, 2025 10:22
@SharglutDev SharglutDev requested a review from Math-R February 19, 2025 10:23
@Wadjetz Wadjetz force-pushed the yci/adapt_timetable_endpoints branch 3 times, most recently from f29dbf1 to bfa4b66 Compare February 19, 2025 10:54
Math-R
Math-R approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

emersion
emersion reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had one last look and got a few more comments!

@Wadjetz Wadjetz force-pushed the yci/adapt_timetable_endpoints branch from f460866 to 9f21aa5 Compare February 20, 2025 13:53
emersion
emersion approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@emersion
Copy link
Member

Please make sure to squash the commits before merging!

@younesschrifi younesschrifi force-pushed the yci/adapt_timetable_endpoints branch from 9f21aa5 to a84f037 Compare February 20, 2025 16:54
@younesschrifi younesschrifi removed the request for review from leovalais February 20, 2025 16:54
@younesschrifi younesschrifi added this pull request to the merge queue Feb 20, 2025
Merged via the queue into dev with commit 0152d77 Feb 20, 2025
27 checks passed
@younesschrifi younesschrifi deleted the yci/adapt_timetable_endpoints branch February 20, 2025 17:31
@SharglutDev SharglutDev mentioned this pull request Feb 24, 2025
Closed
@SharglutDev SharglutDev mentioned this pull request Mar 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais left review comments

@emersion emersion emersion approved these changes

@woshilapin woshilapin woshilapin approved these changes

@flomonster flomonster flomonster approved these changes

@Maymanaf Maymanaf Maymanaf approved these changes

@Math-R Math-R Math-R approved these changes

@shenriotpro shenriotpro shenriotpro approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editoast: adapt timetable endpoint
9 participants
@younesschrifi @codecov-commenter @emersion @woshilapin @flomonster @Maymanaf @leovalais @Math-R @shenriotpro