Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix electrical profile display in speedspacechart #10672

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

RomainValls
Copy link
Contributor

close #10664

@RomainValls RomainValls requested a review from a team as a code owner February 4, 2025 13:17
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 4, 2025
@RomainValls RomainValls self-assigned this Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (14fa21b) to head (02f8d2d).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10672   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files        1079     1079           
  Lines      107473   107473           
  Branches      734      734           
=======================================
  Hits        88024    88024           
  Misses      19409    19409           
  Partials       40       40           
Flag Coverage Δ
editoast 74.29% <ø> (ø)
front 89.41% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@RomainValls RomainValls force-pushed the rvs/front-fix-electrical-profile-display branch 3 times, most recently from 9c9792c to 59060d4 Compare February 6, 2025 15:09
@Maymanaf Maymanaf requested a review from a team as a code owner February 6, 2025 15:46
@RomainValls RomainValls force-pushed the rvs/front-fix-electrical-profile-display branch from b10eb00 to 02f8d2d Compare February 7, 2025 10:09
@RomainValls RomainValls added this pull request to the merge queue Feb 7, 2025
Merged via the queue into dev with commit 02f8d2d Feb 7, 2025
53 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-electrical-profile-display branch February 7, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: the electrical profiles are not correct on the GEV
5 participants