Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: move action buttons in time table train card #10673

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Feb 4, 2025

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner February 4, 2025 13:52
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (9f2a3bf) to head (736b3c2).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10673   +/-   ##
=======================================
  Coverage   81.92%   81.92%           
=======================================
  Files        1079     1079           
  Lines      107274   107274           
  Branches      737      737           
=======================================
+ Hits        87882    87883    +1     
+ Misses      19352    19351    -1     
  Partials       40       40           
Flag Coverage Δ
editoast 74.21% <ø> (+<0.01%) ⬆️
front 89.47% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@Uriel-Sautron Uriel-Sautron force-pushed the usn/move-timetable-traincard-buttons branch from 92ddaa5 to 8efce5a Compare February 6, 2025 11:16
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you for the last fix. You can fix and resolve the last comment when done :)

@Uriel-Sautron Uriel-Sautron force-pushed the usn/move-timetable-traincard-buttons branch 5 times, most recently from 3b3bf13 to 56a9913 Compare February 6, 2025 13:55
  - change action-buttons css class

Co-authored-by: Math_R_ <[email protected]>
Signed-off-by: Uriel-Sautron <[email protected]>
@Uriel-Sautron Uriel-Sautron force-pushed the usn/move-timetable-traincard-buttons branch from 56a9913 to a653e51 Compare February 6, 2025 14:13
@Uriel-Sautron Uriel-Sautron force-pushed the usn/move-timetable-traincard-buttons branch from a653e51 to 736b3c2 Compare February 6, 2025 14:16
@SharglutDev SharglutDev enabled auto-merge February 6, 2025 14:22
@SharglutDev SharglutDev added this pull request to the merge queue Feb 6, 2025
Merged via the queue into dev with commit 736b3c2 Feb 6, 2025
53 checks passed
@SharglutDev SharglutDev deleted the usn/move-timetable-traincard-buttons branch February 6, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move timetable train's action card to the right when hover
5 participants